Age | Commit message (Collapse) | Author | Files | Lines |
|
We would currently leak the record in case we skip a line, fix this by
xfree()ing the memory in these cases.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
|
|
Follow commit bdb9efef ("oui: Make parsing of oui.conf more robust") and
make parsing the upd.conf, tcp.conf and ether.conf files more robust
against format flaws. ALso here, in the worst case, we would end up
dereferencing a null pointer.
The null pointer dereference was found by the Coverity scanner.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
|
|
Make comments related to skipping of lines a bit clearer.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
|
|
Manual merge was necessary, since Jon and Stephen were both editing
the mausezahn.8 man page.
Conflicts:
mausezahn.8
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Minor sentence edits to make better readability, removed extra whitespace,
removed double-quotes on option ( -t ) to make consistent.
Signed-off-by: Jon Schipp <jonschipp@gmail.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Signed-off-by: Stephen Wadeley <swadeley@redhat.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Signed-off-by: Stephen Wadeley <swadeley@redhat.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Signed-off-by: Stephen Wadeley <swadeley@redhat.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Signed-off-by: Stephen Wadeley <swadeley@redhat.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Signed-off-by: Stephen Wadeley <swadeley@redhat.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Signed-off-by: Stephen Wadeley <swadeley@redhat.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Signed-off-by: Stephen Wadeley <swadeley@redhat.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Signed-off-by: Stephen Wadeley <swadeley@redhat.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Just tell GCC that those paths are unexpected.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Bail out if it should ever fail. Detected by coverty in the
translate_pcap_to_txf() path.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Only close the very first pcap file of multi-pcap files once, and not
once during next_multi_pcap_file and once during exit.
Discovered by Coverty scanner.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
If this is ever the case, bail out.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
In case of an error, just panic, to make sure we always get a val >= 1.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Do not leak the socket resource when bailing out in error case.
Found by the coverty scanner.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Include curve.h so that it also finds the selftest.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
We need to zero out data before we actually do the bind, otherwise
uninitialized crap can be in saddr.
Found by coverty scanner.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Signed-off-by: Stephen Wadeley <swadeley@redhat.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Signed-off-by: Stephen Wadeley <swadeley@redhat.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Be paraniod and make a selftest.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Move the curve selftest to its own file.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Prevent IRQ affinity restore of lo device, since we do not collect it
and since it doesn't have a IRQ number. This fixes a warning on trafgen
and netsniff-ng when exiting.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Add a small comment about the 700ms.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
In the unlikely case of the oui.conf file not conforming to the required
format (e.g. by the user supplying one by himself), we would end up -
in the worst case dereferencing a null pointer, if the condiition
(ptr = strstr(buff, ", ")) is false. Thus make the entire parsing a bit
more robust and just ignore lines not following the required format.
The null pointer dereference was found by the Coverity scanner.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
|
|
Put a comment there explaining why we randomize atto.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
We never use or report it anywhere, so remove it.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
|
|
Since we've added '+'/'-' for max/min CPU values, we also need to shift
once whitespace to the left to properly align ncurses display again.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
This is not the top number of CPUs but the total number. Rename the
variable to not confuse this.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
|
|
Fix some minor nits in the description part and remove a superfluous
comma in the description of option -d/--dev.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
|
|
Instead of just giving the percentage of memory usage, report the total,
used, active and inactive memory values. Also report total, free and
cached for swap.
Instead of reporting the memory in the 'sys' line add two new lines for
these reports and use the free space to report the total number of
processes.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
|
|
These stats values are not reported anywhere in relative terms, so it
makes no sense to calculate the difference for them.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
|
|
It's sufficient to calculate the difference of tx_bytes only once.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
|
|
In case we add new stats values, j might be higher already when entering
the loop. As j will have the proper number anyway, there is no point in
re-initializing.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
|
|
That's a first part of the manpage edit for now.
Signed-off-by: Jon Schipp <jonschipp@gmail.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
This functionality is available in the kernel, so make it also
available for use in bpfc.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Also display the least heavy hitter for the relative and absolute IRQ
list. Also check that the number passed with -n is actually 1 or larger.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
|
|
Along with the topmost heavy hitters, we always display the least heavy
hitter (unless there's only 1 CPU). This is not influenced by the -n
command line parameter, so also display the according additional CPU in
the header line.
Also update the manpage accordingly.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
|
|
Initial zsh autocompletion support for mausezahn!
Signed-off-by: Hideo Hattori <hhatto.jp@gmail.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
We should also remove those functions! Arg. While at it, slightly clean
up a bit.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
This is not really related to curve functions, so move it out from
there.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Move them into a separate header, structures and inline functions,
since they are more or less independant of curve.h.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Move them into a separate header file, so that it is more clean.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Argh, forgot to rename variables in read_blob_or_die/write_blob_or_die.
ioops.c: In function ‘read_blob_or_die’:
ioops.c:105:30: error: ‘len’ undeclared (first use in this function)
ioops.c:105:30: note: each undeclared identifier is reported only once for each function it appears in
ioops.c: In function ‘write_blob_or_die’:
ioops.c:116:31: error: ‘len’ undeclared (first use in this function)
make: *** [netsniff-ng/ioops.o] Error 1
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|