Age | Commit message (Collapse) | Author | Files | Lines |
|
This way the coverity scanner will no longer complain about dereference
before NULL checks right before xfree().
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
|
|
In certain error cases, the file/socket descriptors are not closed
in geoip_get_database(). This was discovered by the coverity scanner.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
|
|
Check return value of pkt_pull before dereferencing it (even though we
check the packet length before and pkt_pull _should_ never return NULL).
This was discovered by the coverity scanner.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
|
|
The coverity scanner found the macro used as argument to sizeof
suspicious. Use sizeof the destination buffer instead.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
|
|
Check return value of pkt_pull before dereferencing it. This was
discovered by the coverity scanner.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
|
|
Remove two trailing whitespaces on emtpy lines.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
|
|
Allow to define custom compile flags, e.g. ...
make CFLAGS="-O2 -Wall"
... and also allow to overwrite ccache variable:
make CCACHE= all
Also do some minor fixes when built with -O2 -Wall.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
The Documentation/ folder no longer exists. Either everything important
can be found in the man pages or other documentation files. Fix the
mentioning of Documentation/.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Also update examples for the man-page.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Also allow for ...
- hex: 0xff, xff
- binary: 0b11110000, b11110000
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
We can just replace int with uin32_t, that's no problem. Also
fix one case where we moved to uint16_t.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Add a more detailled description of netsniff-ng's -D option into
the man-page.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
With commit [1] in the kernel, we can also store the timestamp
source in the pcap packet header for later analysis. We do this
by splitting the netsniff-ng's u32 ifindex into u16 tsource and
u16 ifindex. Older kernel do not support the timestamp source in
PF_PACKET, so it will stay 0 and is compatible with older
netsniff-ng binaries.
[1] http://thread.gmane.org/gmane.linux.network/266878/
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
When doing to successive ``make install'' ln will throw an error
that the symlink already exist, so simply force it to overwrite.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Mention pkg-config and gpg as optional tools for verifying tags resp.
getting build flags. If they are not wanted / present, then relative
Makefiles need to be edited by hand.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Finish writing up the remaining section of the astraceroute man
page.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Here's at least a start that needs some more details to be filled
out during the next week.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Add a newline after this long one. Also, after opening braces there
should be no newline.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Rename it to not confuse the build with header inclusions.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Only have Makefile specific folders in the project root where the
binaries are stored, the rest should be part of the repository root.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Finish the last part, which is usage examples.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Counter description was missing.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
This adds the packet configuration syntax section for trafgen's
man page.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
There are still 3 sections on todo, but for now we can already push
out the option section that is ready.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Add an initial version of the trafgen man-page. There are still a couple
of TODO marked section that need to be addressed in follow-up commits.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
This was left forgotten during writing of the man page, so fix it
up and add missing documentation.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Now, with PF_PACKET's extension, we can see what kind of sw/hw
timestamp is being reported to us [1]. Thus, report it in the
dissector.
[1] http://thread.gmane.org/gmane.linux.network/266878/
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Set TX timestamping to HWTSTAMP_TX_OFF. We do not use it, therefore
do not waist time keeping track of it.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
For TX this call is completly useless and has no effect whatsoever.
Therefore, remove it. For the RX part, this call makes perfect
sense, not for the other one currently.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Just add yet another example for ethtool, nothing more.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
|
|
TP_STATUS_AVAILABLE is 0, thus the condition will always be
successful. Fix this bug by properly checking kernel flags.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
This is an initial version of flowtop's man page that includes
a writeup of its purpose, what it can do and what its limits are
and what options are available for use.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
The list of used config files missed the geoip.conf.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
It contained an non-existing file. So remove it from the
ignore list.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
It is accessable e.g. through:
git pull git://repo.or.cz/netsniff-ng-old.git with-mausezahn
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Maybe in short term future, before the next release, we will think
about putting the README file for users into DOCDIRE, since the
rest is not really interesting for users, but probably only for
developers.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
We should only put the things here that are interesting for users,
thus, add steps to verify a release from the Workflow document.
[1] http://pub.netsniff-ng.org/docs/Workflow
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Lets move CodingStyle, SubmittingPatches, and Sponsors into the
root directory of netsniff-ng and remove the Documentation folder.
Some of those files are quite bloated, and most of these things
should be in the man-pages anyway. They should be the only big
sources of documentation, nothing else.
The rest is currently put here: http://pub.netsniff-ng.org/docs/
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Add the known bug from Documentation/KnownIssues into the man page
so that at some point in time, we can remove this document and
maintain that stuff within the man page.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
When we're still root, we tell the kernel to lock/protect all current
and future pages in memory so that they will not be swapped out in
case the system uses up too much. Now when we do xzmalloc_aligned(),
it calls internally posix_memalign() that can call mmap(2), thus we
will get an EAGAIN as errno, since we're not root anymore and since
we wanted to touch sth. that belongs to root. Nasty. Fix this up by
only protecting these pages when we do not use -u/-g.
Reported-by: Doug Burks <doug.burks@gmail.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Jon Schipp reported that a arbitrary packet config
such as ...
{
"MyPacket",
"MyPacket",
"MyPacket",
"MyPacket",
"MyPacket",
"MyPacket",
"MyPacket",
"MyPacket",
}
... doesn't work anymore, although it used to work. This
regression was introduced by commit f9591eebe40c ("trafgen:
lexer/parser: fix cpu() selection and whitespacing").
Reported-by: Jon Schipp <jonschipp@gmail.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Fix wording and phrasing in some of the usage examples.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
|
|
Replace 'priviledges' by 'privileges'.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
|
|
Replace 'networkoing' by 'networking'.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
|
|
When using netsniff-ng with dropping priviledges, we have to introduce
another pcap helper function that is called once before we drop the
priviledges. In this function we have to invoke the disc I/O scheduler
policy, because it needs priviledges. Otherwise netsniff-ng will fail
with "Failed to set io prio for pid" on startup, since we're not root
anymore.
Reported-by: Doug Burks <doug.burks@gmail.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
E.g. when executing trafgen on tap devices, trafgen will complain
that it is not up and running although it was brought up. Remove
this usability restriction and let the kernel decide if it may
send the packets or not.
Reported-by: Aimal Khan <aimal.khan98@gmail.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Add a section of known bugs/todos for bpfc.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Fill in the rest of the gaps for this man page.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|