| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
Only attempt to close the file descriptor in error cases where it is
actually open.
This was discovered by the coverity scanner.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
|
|
The return value is never used by the callers, so we don't need to
return anything.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
|
|
Add a uniform header comment to the two scripts as present in
other scripts in this repository as well. Also rename build_nacl.sh
into nacl_build.sh to stay conform in naming. For this, also update
all mentions of build_nacl.sh to nacl_build.sh.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Add a missing header file description as present in other scripts,
for example. Also credit Stefan for his help.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Both, the IP and ICMP checksums use the same algorithm from RFC1071.
Thus, it's enough if we give csumip an alias to csumicmp, so that it
can be used in trafgen packet configurations. It's calculated from
the ICMP header + data, with value 0 for this field.
Suggested-by: Jon Schipp <jonschipp@gmail.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Add different bpf opcode pretty printer to support a variety of
output formats for netsniff-ng, xt_bpf, tcpdump, C-like and make
future integration of formats easier.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Since we list all authors for their contributions in the AUTHORS,
add Peter Stuge for his improvement on the build system.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
When setting a prefix from the build system, also pass this through the
hard coded strings for config file locations in the toolkit, so that the
installed files (which use PREFIX) can be properly found.
Suggested-by: Peter Stuge <peter@stuge.se>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Hw timestaming is currently done, if we have the header file from
the kernel available. If it fails, we currently bail out, which is
bullshit. Just returning is enough, since some users might have the
header available, but not a NIC supporting hw timestaming.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
We do not assign or use this particular state, so just remove it from
the enum. We continue anyway in the while loop in that case.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Make whitespacing more uniform to coding conventions and also simplify
some fubar if + xfree combinations by using free only.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Remove various unreachable sections from the switch statements. This
was detected by the coverty scanner.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
If the new pointer is NULL anyway, this results in a constant expression
during compile time (NULL != NULL) where a barrier is left out. Thus, it
will have no different effect using rcu_assign_pointer() than assigning
it directly.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Check various setsockopt return values and exit accordingly if some
of them just fuck up.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
If something screws up, which is rather unlikely, but if it happens,
let the user know.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Before we do calculations on statistics, check if we really got them.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Let us check the return value when the timer triggers a TX flush
request to the kernel. However, ignore the case of BADFS and NOBUFS.
The socket could already have been closed before the timer triggers
in the first case, and in the second, we just let the next timer
continue processing if currently the buffer space is exhausted.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Coverty detected a misuse of the getnameinfo API, thus, we
need to fix the length parameter.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Coverty detected that the variable "dir" going out of scope leaks the
storage it points to. Thus close the handle first!
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Coverty detected, when we are in an error condition, we do not close
file handles, but just return instead. Thus, reorder statements, so
that file handles are closed for sure.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Covertiy detected that when we redirect sdtin/stdout either via
``-i -'' or ``-o -'', we also need to properly close it when it
goes out of scope.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Make sure raw is null-terminated after we read the buffer that we
receive from the remote end. Detected by coverty scan.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Some of the official Git mirror URLs were deprecated, so update them.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Do the announcement before the tagging is done, since we read out
the last tag in creating the shortlog.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
To automatically create the shortlog for the .MAIL_MSG, we use
git shortlog. However, we do not want to include old stuff, so
let only commits pass that were between the previous release and
now. (Untested for now, since there is no futher tag.)
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Trying to document the workflow that comes along with using this Git
repository. Further ideas, additions to this document are welcome to
create a unified frame for all maintainers, developers and (advanced)
users.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
It is useful to have as much as possible scripted, to be less error-prone
and to have a uniform and simple workflow. Therefore, make the tagging,
tarball and mail message in a uniform way.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Call pkg-config --cflags and pkg-config --libs to find correct CFLAGS
and LDFLAGS respectively.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
Call pkg-config --cflags and pkg-config --libs to find correct CFLAGS
and LDFLAGS respectively.
Signed-off-by: Peter Stuge <peter@stuge.se>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
|
|
We decided to get rid of the old Git history and start a new one for
several reasons:
*) Allow / enforce only high-quality commits (which was not the case
for many commits in the history), have a policy that is more close
to the one from the Linux kernel. With high quality commits, we
mean code that is logically split into commits and commit messages
that are signed-off and have a proper subject and message body.
We do not allow automatic Github merges anymore, since they are
total bullshit. However, we will either cherry-pick your patches
or pull them manually.
*) The old archive was about ~27MB for no particular good reason.
This basically derived from the bad decision that also some PDF
files where stored there. From this moment onwards, no binary
objects are allowed to be stored in this repository anymore.
The old archive is not wiped away from the Internet. You will still
be able to find it, e.g. on git.cryptoism.org etc.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
|
