summaryrefslogtreecommitdiff
path: root/ring.h
AgeCommit message (Expand)AuthorFilesLines
2013-03-16ring: don't care if we cannot active hw timestampingDaniel Borkmann1-13/+8
2013-03-15all: import netsniff-ng 0.5.8-rc0 sourceDaniel Borkmann1-0/+174
ignoremode:
authorArnd Bergmann <arnd@arndb.de>2016-03-23 11:34:36 +0100
committerDoug Ledford <dledford@redhat.com>2016-04-06 10:37:16 -0400
commit2fe7857176ad6b70e8b2a318506525410e774f34 (patch)
tree8e80dcb5d585a4945e2c4b7ee2b528da37e667d0 /Documentation
parent9967c70abc929e9b910be8d419fdf6a85411a066 (diff)
i40iw: avoid potential uninitialized variable use
gcc finds that the i40iw_make_cm_node() function in the recently added i40iw driver uses an uninitilized variable as an index into an array if CONFIG_IPV6 is disabled and the driver uses IPv6 mode: drivers/infiniband/hw/i40iw/i40iw_cm.c: In function 'i40iw_make_cm_node': drivers/infiniband/hw/i40iw/i40iw_cm.c:2206:52: error: 'arpindex' may be used uninitialized in this function [-Werror=maybe-uninitialized] ether_addr_copy(cm_node->rem_mac, iwdev->arp_table[arpindex].mac_addr); As far as I can tell, this code path can not be used because the ipv4 variable is always set with CONFIG_IPV6 is disabled, but it's better to be sure and prevent the undefined behavior, as well as shut up that warning in a proper way. This adds an 'else' clause for the case we get the warning about, causing the function to return an error in a controlled way. To avoid adding extra mess with combined io()/#ifdef clauses, I'm also converting the existing #ifdef into a more readable if(IS_ENABLED()) check. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Fixes: f27b4746f378 ("i40iw: add connection management code") Acked-by: Mustafa Ismail <Mustafa.ismail@intel.com> Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'Documentation')