summaryrefslogtreecommitdiff
path: root/sysctl.h
AgeCommit message (Expand)AuthorFilesLines
2015-07-20sysctl: Add sysctl module with /proc/sys helpersVadim Kochan1-0/+7
oscript>
authorMayurkumar Patel <mayurkumar.patel@intel.com>2016-09-08 15:07:56 -0500
committerBjorn Helgaas <bhelgaas@google.com>2016-09-14 14:24:31 -0500
commitfad214b0aa726ee21adcac4308d388efcb89d6bd (patch)
tree3f0c8367e3dcb08641f3fafe60996d6519b79d16
parent70e8b40176c75d3544024e7c934720b11a8a11bf (diff)
PCI: pciehp: Process all hotplug events before looking for new ones
Previously we accumulated hotplug events, then processed them, essentially like this: events = 0 do { status = read(Slot Status) status &= EVENT_MASK # only look at events events |= status # accumulate events write(Slot Status, events) # clear events } while (status) process events The problem is that as soon as we clear events in Slot Status, the hardware may send notifications for new events, and we lose information about the first events. For example, we might see two Presence Detect Changed events, but lose the fact that the slot was temporarily empty: read PCI_EXP_SLTSTA_PDC set, PCI_EXP_SLTSTA_PDS clear # slot empty write PCI_EXP_SLTSTA_PDC # clear PDC event read PCI_EXP_SLTSTA_PDC set, PCI_EXP_SLTSTA_PDS set # slot occupied The current code does not process a removal; it only processes the insertion, which fails because we didn't remove the original device. To avoid this problem, read Slot Status once and process all the events before reading it again, like this: do { read events clear events process events } while (events) [bhelgaas: changelog, add external loop around pciehp_isr()] Tested-by: Lukas Wunner <lukas@wunner.de> Signed-off-by: Mayurkumar Patel <mayurkumar.patel@intel.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Diffstat