From 85f3536846adb8da882227b40ddbe0bc91f3ce71 Mon Sep 17 00:00:00 2001
From: Vadim Kochan <vadim4j@gmail.com>
Date: Sun, 17 Dec 2017 23:25:40 +0200
Subject: flowtop: Use RCU flow deletion from process entry

Use cds_list_del_rcu for safer deletion flow from the process flow
list to prevent possible use-after-free by UI thread when it is
refreshing the processes.

It may fix the #183 issue.

Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
 flowtop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/flowtop.c b/flowtop.c
index 0a3c514..8b69d65 100644
--- a/flowtop.c
+++ b/flowtop.c
@@ -477,7 +477,7 @@ static int flow_list_del_entry(struct flow_list *fl, const struct nf_conntrack *
 	n = flow_list_find_id(fl, nfct_get_attr_u32(ct, ATTR_ID));
 	if (n) {
 		if (n->proc) {
-			cds_list_del(&n->proc_head);
+			cds_list_del_rcu(&n->proc_head);
 			n->proc->flows_count--;
 		}
 
-- 
cgit v1.2.3-54-g00ecf

orm'><form method='get'>
<input type='hidden' name='id' value='ff8d6facda455c129357e891e31dd0aa21a96ed0'/><select name='h' onchange='this.form.submit();'>
<option value='emaclite-cleanup'>emaclite-cleanup</option>
<option value='master'>master</option>
<option value='nds-private-remove' selected='selected'>nds-private-remove</option>
<option value='packet-loop-back'>packet-loop-back</option>
<option value='packet-rx-pump-back'>packet-rx-pump-back</option>
</select> <input type='submit' value='switch'/></form></td></tr>
<tr><td class='sub'>net-next plumbings</td><td class='sub right'>Tobias Klauser</td></tr></table>
<table class='tabs'><tr><td>
<a href='/cgit.cgi/linux/net-next.git/?h=nds-private-remove'>summary</a><a href='/cgit.cgi/linux/net-next.git/refs/?h=nds-private-remove&amp;id=ff8d6facda455c129357e891e31dd0aa21a96ed0'>refs</a><a href='/cgit.cgi/linux/net-next.git/log/?h=nds-private-remove'>log</a><a href='/cgit.cgi/linux/net-next.git/tree/?h=nds-private-remove&amp;id=ff8d6facda455c129357e891e31dd0aa21a96ed0'>tree</a><a class='active' href='/cgit.cgi/linux/net-next.git/commit/?h=nds-private-remove&amp;id=ff8d6facda455c129357e891e31dd0aa21a96ed0'>commit</a><a href='/cgit.cgi/linux/net-next.git/diff/?h=nds-private-remove&amp;id=ff8d6facda455c129357e891e31dd0aa21a96ed0'>diff</a></td><td class='form'><form class='right' method='get' action='/cgit.cgi/linux/net-next.git/log/'>
<input type='hidden' name='h' value='nds-private-remove'/><input type='hidden' name='id' value='ff8d6facda455c129357e891e31dd0aa21a96ed0'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='content'><div class='cgit-panel'><b>diff options</b><form method='get'><input type='hidden' name='h' value='nds-private-remove'/><input type='hidden' name='id' value='ff8d6facda455c129357e891e31dd0aa21a96ed0'/><table><tr><td colspan='2'/></tr><tr><td class='label'>context:</td><td class='ctrl'><select name='context' onchange='this.form.submit();'><option value='1'>1</option><option value='2'>2</option><option value='3' selected='selected'>3</option><option value='4'>4</option><option value='5'>5</option><option value='6'>6</option><option value='7'>7</option><option value='8'>8</option><option value='9'>9</option><option value='10'>10</option><option value='15'>15</option><option value='20'>20</option><option value='25'>25</option><option value='30'>30</option><option value='35'>35</option><option value='40'>40</option></select></td></tr><tr><td class='label'>space:</td><td class='ctrl'><select name='ignorews' onchange='this.form.submit();'><option value='0' selected='selected'>include</option><option value='1'>ignore</option></select></td></tr><tr><td class='label'>mode:</td><td class='ctrl'><select name='dt' onchange='this.form.submit();'><option value='0' selected='selected'>unified</option><option value='1'>ssdiff</option><option value='2'>stat only</option></select></td></tr><tr><td/><td class='ctrl'><noscript><input type='submit' value='reload'/></noscript></td></tr></table></form></div><table summary='commit info' class='commit-info'>
<tr><th>author</th><td>Linus Torvalds &lt;torvalds@linux-foundation.org&gt;</td><td class='right'>2016-07-23 11:22:37 +0900</td></tr>
<tr><th>committer</th><td>Linus Torvalds &lt;torvalds@linux-foundation.org&gt;</td><td class='right'>2016-07-23 11:22:37 +0900</td></tr>
<tr><th>commit</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/commit/?h=nds-private-remove&amp;id=ff8d6facda455c129357e891e31dd0aa21a96ed0'>ff8d6facda455c129357e891e31dd0aa21a96ed0</a> (<a href='/cgit.cgi/linux/net-next.git/patch/?id=ff8d6facda455c129357e891e31dd0aa21a96ed0'>patch</a>)</td></tr>
<tr><th>tree</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/tree/?h=nds-private-remove&amp;id=ff8d6facda455c129357e891e31dd0aa21a96ed0'>04890c770e0429cb08313fc6c99657436099889c</a></td></tr>
<tr><th>parent</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/commit/?h=nds-private-remove&amp;id=47ef4ad2684d380dd6d596140fb79395115c3950'>47ef4ad2684d380dd6d596140fb79395115c3950</a> (<a href='/cgit.cgi/linux/net-next.git/diff/?h=nds-private-remove&amp;id=ff8d6facda455c129357e891e31dd0aa21a96ed0&amp;id2=47ef4ad2684d380dd6d596140fb79395115c3950'>diff</a>)</td></tr><tr><th>parent</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/commit/?h=nds-private-remove&amp;id=32f0c4afb4363e31dad49202f1554ba591d649f2'>32f0c4afb4363e31dad49202f1554ba591d649f2</a> (<a href='/cgit.cgi/linux/net-next.git/diff/?h=nds-private-remove&amp;id=ff8d6facda455c129357e891e31dd0aa21a96ed0&amp;id2=32f0c4afb4363e31dad49202f1554ba591d649f2'>diff</a>)</td></tr></table>
<div class='commit-subject'>Merge branch 'for-linus' of git://git.kernel.dk/linux-block</div><div class='commit-msg'>Pull NVMe fix from Jens Axboe:
 "Late addition here, it's basically a revert of a patch that was added
  in this merge window, but has proven to cause problems.

  This is swapping out the RCU based namespace protection with a good
  old mutex instead"

* 'for-linus' of git://git.kernel.dk/linux-block:
  nvme: Remove RCU namespace protection
</div><div class='diffstat-header'><a href='/cgit.cgi/linux/net-next.git/diff/?h=nds-private-remove&amp;id=ff8d6facda455c129357e891e31dd0aa21a96ed0'>Diffstat</a></div><table summary='diffstat' class='diffstat'>