From e0a7ae85351de7ebc43af1fe5f04e650c6736201 Mon Sep 17 00:00:00 2001 From: Tobias Klauser Date: Tue, 9 Sep 2014 14:34:38 +0200 Subject: sock: Error out if setting of the system socket memory fails Currently we ignore the return value of the write() calls to /proc/sys/net/core/{r,w}mem_{default,max} in set_system_socket_mem(). Better check the return value and notify the user about it. This also fixes a clang compiler warning about a variable explicitely assigned to itself. Signed-off-by: Tobias Klauser --- sock.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sock.c b/sock.c index e5f6eac..6c973ed 100644 --- a/sock.c +++ b/sock.c @@ -177,7 +177,8 @@ static void set_system_socket_mem(int which, int val) slprintf(buff, sizeof(buff), "%d", val); ret = write(fd, buff, strlen(buff)); - ret = ret; + if (ret < 0) + panic("Cannot set system socket memory!\n"); close(fd); } -- cgit v1.2.3-54-g00ecf