From 679e6211238039322272e0d3d085fab0d7c5c91d Mon Sep 17 00:00:00 2001 From: Tobias Klauser Date: Tue, 21 Apr 2015 18:05:36 +0200 Subject: dev: Close socket in error path of device_ifindex_get() If the ioctl() fails, the socket still needs to be closed instead of returning directly. This issue was discovered using the Coverity scanner. Fixes: f43bbe9 ("mac80211: Check existence of generated monX device") Signed-off-by: Tobias Klauser --- dev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'dev.c') diff --git a/dev.c b/dev.c index aa0ca4e..2b3a7a5 100644 --- a/dev.c +++ b/dev.c @@ -28,9 +28,10 @@ int device_ifindex_get(const char *ifname) ret = ioctl(sock, SIOCGIFINDEX, &ifr); if (ret) - return -1; + index = -1; + else + index = ifr.ifr_ifindex; - index = ifr.ifr_ifindex; close(sock); return index; -- cgit v1.2.3-54-g00ecf