From e07a1ee28df19afc6cd7360010b6ba862d29505f Mon Sep 17 00:00:00 2001 From: Tobias Klauser Date: Fri, 14 Jun 2013 14:34:28 +0200 Subject: sock: Check return value of setsockopt() in set_tcp_nodelay() Check the return value of setsockopt() and panic in case it is not 0, as in the other setsockopt() wrapper functions. This issue was discovered by the Coverity scanner. Signed-off-by: Tobias Klauser --- sock.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'sock.c') diff --git a/sock.c b/sock.c index 40e4504..1cefb83 100644 --- a/sock.c +++ b/sock.c @@ -65,8 +65,11 @@ void set_socket_keepalive(int fd) void set_tcp_nodelay(int fd) { - int one = 1; - setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, &one, sizeof(one)); + int ret, one = 1; + + ret = setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, &one, sizeof(one)); + if (unlikely(ret)) + panic("Cannot set TCP nodelay!\n"); } int set_ipv6_only(int fd) -- cgit v1.2.3-54-g00ecf