diff options
author | Tyler Hicks <tyhicks@canonical.com> | 2013-11-13 10:09:42 -0800 |
---|---|---|
committer | Tyler Hicks <tyhicks@canonical.com> | 2013-11-14 12:12:15 -0800 |
commit | 2000f5beabc9c6baf084de5f7879975408e3652c (patch) | |
tree | 73840a7dd710710ef203cade2cfc31e873d28abb /sound/soc/mxs | |
parent | 42a2d923cc349583ebf6fdd52a7d35e1c2f7e6bd (diff) |
eCryptfs: file->private_data is always valid
When accessing the lower_file pointer located in private_data of
eCryptfs files, there is no need to check to see if the private_data
pointer has been initialized to a non-NULL value. The file->private_data
and file->private_data->lower_file pointers are always initialized to
non-NULL values in ecryptfs_open().
This change quiets a Smatch warning:
CHECK /var/scm/kernel/linux/fs/ecryptfs/file.c
fs/ecryptfs/file.c:321 ecryptfs_unlocked_ioctl() error: potential NULL dereference 'lower_file'.
fs/ecryptfs/file.c:335 ecryptfs_compat_ioctl() error: potential NULL dereference 'lower_file'.
Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Geyslan G. Bem <geyslan@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'sound/soc/mxs')