diff options
| author | Heiner Kallweit <hkallweit1@gmail.com> | 2016-03-10 20:52:21 +0100 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2016-03-15 15:28:55 +0100 |
| commit | 1d1b564ff852944a10b524f21dfb78818bd43f52 (patch) | |
| tree | 57e8a59d8488e81b230222c474fd337572c353c2 | |
| parent | 43a4a04d4ddb268373d5857c7a7bcbe3658e5b48 (diff) | |
hid: thingm: reorder calls in thingm_probe
When reviewing another thingm patch Benjamin Tissoires pointed out
the following: "The problem here is that hid_hw_start() is called
before thingm_version() which allows user space to briefly introduce
races between thingm_version() and any hidraw requests.
The mutex will not help here as it is initialized after hid_hw_start()
and only used for protecting the concurrent access of the rgb."
Avoid this possible issue by calling hid_hw_start() later in the
probe function.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>