/* * netsniff-ng - the packet sniffing beast * Copyright 2011 Daniel Borkmann, rewritten * Copyright 1991-2007 Kawahara Lab., Kyoto University * Copyright 2000-2005 Shikano Lab., Nara Institute of Science and Technology * Copyright 2005-2007 Julius project team, Nagoya Institute of Technology * All rights reserved * Subject to the GPL, version 2. */ #ifndef PATRICIA_H #define PATRICIA_H #include #include "built_in.h" struct patricia_node { void *key; size_t klen; struct sockaddr_storage *addr; size_t alen; union { int data; int thres_bit; } value; struct patricia_node *l, *r; } __cacheline_aligned; extern int ptree_search_data_nearest(void *str, size_t sstr, struct sockaddr_storage *addr, size_t *alen, struct patricia_node *root); extern int ptree_search_data_exact(void *str, size_t sstr, struct sockaddr_storage *addr, size_t *alen, struct patricia_node *root); extern int ptree_add_entry(void *str, size_t sstr, int data, struct sockaddr_storage *addr, size_t alen, struct patricia_node **root); extern void ptree_del_entry(void *str, size_t sstr, struct patricia_node **root); extern void ptree_get_key(int data, struct patricia_node *node, struct patricia_node **wanted); extern void ptree_get_key_addr(struct sockaddr_storage *addr, size_t alen, struct patricia_node *node, struct patricia_node **wanted); extern void ptree_display(struct patricia_node *node, int level); extern void ptree_free(struct patricia_node *root); #endif /* PATRICIA_H */ ref='/cgit.cgi/linux/net-next.git/refs/?h=nds-private-remove&id=a79a5276aa2f844bd368c1d3d5a625e1fbefd989'>refslogtreecommitdiff
path: root/fs/autofs4/inode.c
e='1'>1
AgeCommit message (Expand)AuthorFilesLines
space:
mode:
authorIago Abal <mail@iagoabal.eu>2017-01-11 14:00:21 +0100
committerVinod Koul <vinod.koul@intel.com>2017-01-25 15:35:11 +0530
commit91539eb1fda2d530d3b268eef542c5414e54bf1a (patch)
tree960f5ca6342ad20837aff18aad6e8ecd7da32fd6 /fs/bfs/file.c
parent6610d0edf6dc7ee97e46ab3a538a565c79d26199 (diff)
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the following double-lock bug: Double lock: 1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236; 2. call to function `pl330_release_channel' immediately after; 3. call to function `dma_pl330_rqcb' in line 1753; 4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505. I have fixed it as suggested by Marek Szyprowski. First, I have replaced `pch->lock' with `pl330->lock' in functions `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids the double-lock by acquiring a different lock than `dma_pl330_rqcb'. NOTE that, as a result, `pl330_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'fs/bfs/file.c')