/* * netsniff-ng - the packet sniffing beast * Copyright (C) 2012 Christoph Jaeger * Subject to the GPL, version 2. */ #ifndef PKT_BUFF_H #define PKT_BUFF_H #include "hash.h" #include "built_in.h" #include "proto.h" #include "xmalloc.h" struct pkt_buff { /* invariant: head <= data <= tail */ uint8_t *head; uint8_t *data; uint8_t *tail; struct protocol *dissector; uint32_t link_type; struct sockaddr_ll *sll; }; static inline struct pkt_buff *pkt_alloc(uint8_t *packet, unsigned int len) { struct pkt_buff *pkt = xmalloc(sizeof(*pkt)); pkt->head = packet; pkt->data = packet; pkt->tail = packet + len; pkt->dissector = NULL; return pkt; } static inline void pkt_free(struct pkt_buff *pkt) { xfree(pkt); } static inline unsigned int pkt_len(struct pkt_buff *pkt) { bug_on(!pkt || pkt->data > pkt->tail); return pkt->tail - pkt->data; } static inline uint8_t *pkt_pull(struct pkt_buff *pkt, unsigned int len) { uint8_t *data = NULL; bug_on(!pkt || pkt->head > pkt->data || pkt->data > pkt->tail); if (len <= pkt_len(pkt)) { data = pkt->data; pkt->data += len; } bug_on(!pkt || pkt->head > pkt->data || pkt->data > pkt->tail); return data; } static inline uint8_t *pkt_peek(struct pkt_buff *pkt) { bug_on(!pkt || pkt->head > pkt->data || pkt->data > pkt->tail); return pkt->data; } static inline unsigned int pkt_trim(struct pkt_buff *pkt, unsigned int len) { unsigned int ret = 0; bug_on(!pkt || pkt->head > pkt->data || pkt->data > pkt->tail); if (len <= pkt_len(pkt)) ret = len; pkt->tail -= ret; bug_on(!pkt || pkt->head > pkt->data || pkt->data > pkt->tail); return ret; } static inline uint8_t *pkt_pull_tail(struct pkt_buff *pkt, unsigned int len) { uint8_t *tail = NULL; bug_on(!pkt || pkt->head > pkt->data || pkt->data > pkt->tail); if (len <= pkt_len(pkt)) { tail = pkt->tail; pkt->tail -= len; } return tail; } static inline void pkt_set_dissector(struct pkt_buff *pkt, struct hash_table *table, unsigned int key) { bug_on(!pkt || !table); pkt->dissector = lookup_hash(key, table); while (pkt->dissector && key != pkt->dissector->key) pkt->dissector = pkt->dissector->next; } #endif /* PKT_BUFF_H */ cgit.cgi/linux/net-next.git/diff/tools/perf/builtin-top.c?h=nds-private-remove&id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>diff
path: root/tools/perf/builtin-top.c
diff options
context:
space:
mode:
authorTejun Heo <tj@kernel.org>2017-01-26 16:47:28 -0500
committerTejun Heo <tj@kernel.org>2017-01-26 16:47:28 -0500
commit07cd12945551b63ecb1a349d50a6d69d1d6feb4a (patch)
tree75f65eba7eac9277971082a2d5a4cf1370562c0c /tools/perf/builtin-top.c
parent7ce7d89f48834cefece7804d38fc5d85382edf77 (diff)
cgroup: don't online subsystems before cgroup_name/path() are operational
While refactoring cgroup creation, a5bca2152036 ("cgroup: factor out cgroup_create() out of cgroup_mkdir()") incorrectly onlined subsystems before the new cgroup is associated with it kernfs_node. This is fine for cgroup proper but cgroup_name/path() depend on the associated kernfs_node and if a subsystem makes the new cgroup_subsys_state visible, which they're allowed to after onlining, it can lead to NULL dereference. The current code performs cgroup creation and subsystem onlining in cgroup_create() and cgroup_mkdir() makes the cgroup and subsystems visible afterwards. There's no reason to online the subsystems early and we can simply drop cgroup_apply_control_enable() call from cgroup_create() so that the subsystems are onlined and made visible at the same time. Signed-off-by: Tejun Heo <tj@kernel.org> Reported-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru> Fixes: a5bca2152036 ("cgroup: factor out cgroup_create() out of cgroup_mkdir()") Cc: stable@vger.kernel.org # v4.6+
Diffstat (limited to 'tools/perf/builtin-top.c')