/* * Mausezahn - A fast versatile traffic generator * Copyright (C) 2008-2010 Herbert Haas * * This program is free software; you can redistribute it and/or modify it under * the terms of the GNU General Public License version 2 as published by the * Free Software Foundation. * * This program is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more * details. * * You should have received a copy of the GNU General Public License along with * this program; if not, see http://www.gnu.org/licenses/gpl-2.0.html * */ #include "mz.h" #include "cli.h" #include "mops.h" // ISSUES: // // - Currently only IP/MAC resolution supported (i.e. hw_size=6, pr_size=4) // - Add macro support: commands like request/response should set all params correctly int cmd_arp_hwtype (struct cli_def *cli, const char *command, char *argv[], int argc) { struct mops_ext_arp * pd = clipkt->p_desc; if ( (strncmp(argv[argc-1],"?",1)==0) || (argc!=1) ) { cli_print(cli,"Specify the hardware type (0-ffff, default 1=Eth)\n"); } else if (mops_pdesc_2byte(&pd->hw_type, argv[0], 1, 0, 0xffff)) { cli_print(cli, "Hardware type must be between 0 and ffff\n"); } return CLI_OK; } int cmd_arp_prtype (struct cli_def *cli, const char *command, char *argv[], int argc) { struct mops_ext_arp * pd = clipkt->p_desc; if ( (strncmp(argv[argc-1],"?",1)==0) || (argc!=1) ) { cli_print(cli,"Specify the protocol type (0-ffff, default=800=IP)\n"); } else if (mops_pdesc_2byte(&pd->pr_type, argv[0], 1, 0, 0xffff)) { cli_print(cli, "Protocol type must be between 0 and ffff\n"); } return CLI_OK; } int cmd_arp_hwaddrsize (struct cli_def *cli, const char *command, char *argv[], int argc) { struct mops_ext_arp * pd = clipkt->p_desc; if ( (strncmp(argv[argc-1],"?",1)==0) || (argc!=1) ) { cli_print(cli,"Specify the hardware address size (0-255, default=6)\n"); } else if (mops_pdesc_1byte(&pd->hw_size, argv[0], 0, 0, 255)) { cli_print(cli, "Hardware size must be between 0 and 255\n"); } return CLI_OK; } int cmd_arp_praddrsize (struct cli_def *cli, const char *command, char *argv[], int argc) { struct mops_ext_arp * pd = clipkt->p_desc; if ( (strncmp(argv[argc-1],"?",1)==0) || (argc!=1) ) { cli_print(cli,"Specify the protocol address size (0-255, default=4)\n"); } else if (mops_pdesc_1byte(&pd->pr_size, argv[0], 0, 0, 255)) { cli_print(cli, "Protocol size must be between 0 and 255\n"); } return CLI_OK; } int cmd_arp_opcode (struct cli_def *cli, const char *command, char *argv[], int argc) { struct mops_ext_arp * pd = clipkt->p_desc; if ( (strncmp(argv[argc-1],"?",1)==0) || (argc!=1) ) { cli_print(cli,"Specify the ARP operation code (0-ffff)\n"); cli_print(cli,"Optional keywords: 'request' (default) or 'response'\n"); } else if (mz_strcmp(argv[0],"request", 3)==0) { cli_print(cli, "Set ARP mode to request\n"); pd->opcode = 1; } else if (mz_strcmp(argv[0],"response", 3)==0) { cli_print(cli, "Set ARP mode to response\n"); pd->opcode = 2; } else { cli_print(cli, "Invalid ARP mode\n"); } return CLI_OK; } int cmd_arp_smac (struct cli_def *cli, const char *command, char *argv[], int argc) { struct mops_ext_arp * pd = clipkt->p_desc; if ( (strncmp(argv[argc-1],"?",1)==0) || (argc!=1) ) { cli_print(cli,"Specify a source MAC address (format: XX:XX:XX:XX:XX:XX)\n"); } else { if (mops_pdesc_mac(pd->sender_mac, argv[0])) { cli_print(cli,"Invalid MAC address (use format: XX:XX:XX:XX:XX:XX)\n"); } } return CLI_OK; } int cmd_arp_sip (struct cli_def *cli, const char *command, char *argv[], int argc) { struct mops_ext_arp * pd = clipkt->p_desc; if ( (strncmp(argv[argc-1],"?",1)==0) || (argc!=1) ) { cli_print(cli,"Specify a source IP address (format: A.B.C.D)\n"); } else if (mops_pdesc_ip (pd->sender_ip, argv[0])) { cli_print(cli,"Invalid IP address (use format: A.B.C.D)\n"); } return CLI_OK; } int cmd_arp_tmac (struct cli_def *cli, const char *command, char *argv[], int argc) { struct mops_ext_arp * pd = clipkt->p_desc; if ( (strncmp(argv[argc-1],"?",1)==0) || (argc!=1) ) { cli_print(cli,"Specify a target MAC address (format: XX:XX:XX:XX:XX:XX)\n"); } else if (mops_pdesc_mac(pd->target_mac, argv[0])) { cli_print(cli,"Invalid MAC address (use format: XX:XX:XX:XX:XX:XX)\n"); } return CLI_OK; } int cmd_arp_tip (struct cli_def *cli, const char *command, char *argv[], int argc) { struct mops_ext_arp * pd = clipkt->p_desc; if ( (strncmp(argv[argc-1],"?",1)==0) || (argc!=1) ) { cli_print(cli,"Specify a target IP address (format: A.B.C.D)\n"); } else if (mops_pdesc_ip (pd->target_ip, argv[0])) { cli_print(cli,"Invalid IP address (use format: A.B.C.D)\n"); } return CLI_OK; } int cmd_arp_trailer (struct cli_def *cli, const char *command, char *argv[], int argc) { struct mops_ext_arp * pd = (MOPS_EXT_ARP) clipkt->p_desc; if ( (strncmp(argv[argc-1],"?",1)==0) || (argc!=1) ) { cli_print(cli,"Specify the trailer length (0-2000, default=18)\n"); } else if (mops_pdesc_2byte(&pd->trailer, argv[0], 0, 0, 2000)) { cli_print(cli, "Trailer must be between 0 and 2000\n"); } return CLI_OK; } int cmd_arp_end(struct cli_def *cli, const char *command, char *argv[], int argc) { char prompt[16]; sprintf(prompt, "pkt-%i",clipkt->id); cli_set_configmode(cli, MZ_MODE_PACKET, prompt); return CLI_OK; } c parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'net/ipv4/icmp.c')