/* * Mausezahn - A fast versatile traffic generator * Copyright (C) 2008-2010 Herbert Haas * * This program is free software; you can redistribute it and/or modify it under * the terms of the GNU General Public License version 2 as published by the * Free Software Foundation. * * This program is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more * details. * * You should have received a copy of the GNU General Public License along with * this program; if not, see http://www.gnu.org/licenses/gpl-2.0.html * */ #include "mz.h" #include "mops.h" #include "cli.h" // Calculates the number of TCP transmissions based on SQNR range u_int32_t mops_tcp_complexity_sqnr (struct mops * mp) { u_int32_t a,b,t,result; a = mp->tcp_seq_start; b = mp->tcp_seq_stop; t = mp->tcp_seq_delta; if (!t) return 1; // delta set to zero means no range if (atcp_ack_start; b = mp->tcp_ack_stop; t = mp->tcp_ack_delta; if (!t) return 1; // delta set to zero means no range if (atcp_ctrl_CWR) ? "CRW" : "---", (mp->tcp_ctrl_ECE) ? "ECE" : "---", (mp->tcp_ctrl_URG) ? "URG" : "---", (mp->tcp_ctrl_ACK) ? "ACK" : "---", (mp->tcp_ctrl_PSH) ? "PSH" : "---", (mp->tcp_ctrl_RST) ? "RST" : "---", (mp->tcp_ctrl_SYN) ? "SYN" : "---", (mp->tcp_ctrl_FIN) ? "FIN" : "---"); return 0; } // Add TCP options // // TODO: currently all params are ignored and a default option combination is added. // int mops_tcp_add_option (struct mops* mp, int mss, int sack, int scale, u_int32_t tsval, u_int32_t tsecr) { u_int8_t tcp_default_options[] = { 0x02, 0x04, 0x05, 0xac, // MSS 0x04, 0x02, // SACK permitted 0x08, 0x0a, 0x19, 0x35, 0x90, 0xc3, 0x00, 0x00, 0x00, 0x00, // Timestamps 0x01, // NOP 0x03, 0x03, 0x05 // Window Scale 5 }; /* Kind: 8 Length: 10 bytes +-------+-------+---------------------+---------------------+ |Kind=8 | 10 | TS Value (TSval) |TS Echo Reply (TSecr)| +-------+-------+---------------------+---------------------+ 1 1 4 4 * * The Timestamps option carries two four-byte timestamp fields. The * Timestamp Value field (TSval) contains the current value of the * timestamp clock of the TCP sending the option. * * The Timestamp Echo Reply field (TSecr) is only valid if the ACK bit * is set in the TCP header; if it is valid, it echos a times- tamp * value that was sent by the remote TCP in the TSval field of a * Timestamps option. When TSecr is not valid, its value must be zero. * The TSecr value will generally be from the most recent Timestamp * option that was received; however, there are exceptions that are * explained below. * * A TCP may send the Timestamps option (TSopt) in an initial * segment (i.e., segment containing a SYN bit and no ACK bit), and * may send a TSopt in other segments only if it re- ceived a TSopt in * the initial segment for the connection. * */ memcpy((void*) mp->tcp_option, (void*) tcp_default_options, 20); mp->tcp_option_s = 20; mp->tcp_option_used = 1; return 0; } 'commit info' class='commit-info'> authorIago Abal <mail@iagoabal.eu>2017-01-11 14:00:21 +0100 committerVinod Koul <vinod.koul@intel.com>2017-01-25 15:35:11 +0530 commit91539eb1fda2d530d3b268eef542c5414e54bf1a (patch) tree960f5ca6342ad20837aff18aad6e8ecd7da32fd6 /sound/usb/usx2y parent6610d0edf6dc7ee97e46ab3a538a565c79d26199 (diff)
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the following double-lock bug: Double lock: 1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236; 2. call to function `pl330_release_channel' immediately after; 3. call to function `dma_pl330_rqcb' in line 1753; 4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505. I have fixed it as suggested by Marek Szyprowski. First, I have replaced `pch->lock' with `pl330->lock' in functions `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids the double-lock by acquiring a different lock than `dma_pl330_rqcb'. NOTE that, as a result, `pl330_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'sound/usb/usx2y')