#ifndef TRAFGEN_PROTO_H #define TRAFGEN_PROTO_H #include #include #include enum proto_id { PROTO_NONE = 0, PROTO_ETH, PROTO_PAUSE, PROTO_VLAN, PROTO_ARP, PROTO_MPLS, PROTO_IP4, PROTO_ICMP4, PROTO_IP6, PROTO_ICMP6, PROTO_UDP, PROTO_TCP, __PROTO_MAX, }; enum proto_layer { PROTO_L0, /* invalid layer */ PROTO_L2, PROTO_L3, PROTO_L4, }; struct proto_field; struct proto_hdr; struct proto_ops { enum proto_id id; enum proto_layer layer; void (*header_init)(struct proto_hdr *hdr); void (*header_finish)(struct proto_hdr *hdr); void (*field_changed)(struct proto_field *field); void (*packet_finish)(struct proto_hdr *hdr); void (*packet_update)(struct proto_hdr *hdr); void (*set_next_proto)(struct proto_hdr *hdr, enum proto_id pid); }; struct proto_hdr { const struct proto_ops *ops; uint16_t pkt_offset; uint32_t pkt_id; uint32_t index; struct proto_field *fields; size_t fields_count; bool is_csum_valid; size_t len; }; enum proto_field_func_t { PROTO_FIELD_FUNC_INC = 1 << 0, PROTO_FIELD_FUNC_MIN = 1 << 1, PROTO_FIELD_FUNC_RND = 1 << 2, }; struct proto_field_func { enum proto_field_func_t type; uint32_t min; uint32_t max; int32_t inc; uint32_t val; void (*update_field)(struct proto_field *field); }; struct proto_field { uint32_t id; size_t len; uint32_t shift; uint32_t mask; /* might be negative (e.g. VLAN TPID field) */ int16_t offset; struct proto_field_func func; bool is_set; uint16_t pkt_offset; struct proto_hdr *hdr; }; extern void protos_init(const char *dev); extern void proto_ops_register(const struct proto_ops *ops); extern struct proto_hdr *proto_header_push(enum proto_id pid); extern void proto_header_finish(struct proto_hdr *hdr); extern void proto_packet_finish(void); extern void proto_packet_update(uint32_t idx); extern struct proto_hdr *proto_lower_default_add(struct proto_hdr *hdr, enum proto_id pid); extern struct proto_hdr *proto_lower_header(struct proto_hdr *hdr); extern struct proto_hdr *proto_upper_header(struct proto_hdr *hdr); extern uint8_t *proto_header_ptr(struct proto_hdr *hdr); extern void proto_header_fields_add(struct proto_hdr *hdr, const struct proto_field *fields, size_t count); extern bool proto_field_is_set(struct proto_hdr *hdr, uint32_t fid); extern void proto_field_set_bytes(struct proto_hdr *hdr, uint32_t fid, const uint8_t *bytes); extern void proto_field_set_u8(struct proto_hdr *hdr, uint32_t fid, uint8_t val); extern uint8_t proto_field_get_u8(struct proto_hdr *hdr, uint32_t fid); extern void proto_field_set_u16(struct proto_hdr *hdr, uint32_t fid, uint16_t val); extern uint16_t proto_field_get_u16(struct proto_hdr *hdr, uint32_t fid); extern void proto_field_set_u32(struct proto_hdr *hdr, uint32_t fid, uint32_t val); extern uint32_t proto_field_get_u32(struct proto_hdr *hdr, uint32_t fid); extern void proto_field_set_default_bytes(struct proto_hdr *hdr, uint32_t fid, const uint8_t *bytes); extern void proto_field_set_default_u8(struct proto_hdr *hdr, uint32_t fid, uint8_t val); extern void proto_field_set_default_u16(struct proto_hdr *hdr, uint32_t fid, uint16_t val); extern void proto_field_set_default_u32(struct proto_hdr *hdr, uint32_t fid, uint32_t val); extern void proto_field_set_be16(struct proto_hdr *hdr, uint32_t fid, uint16_t val); extern void proto_field_set_be32(struct proto_hdr *hdr, uint32_t fid, uint32_t val); extern void proto_field_set_default_be16(struct proto_hdr *hdr, uint32_t fid, uint16_t val); extern void proto_field_set_default_be32(struct proto_hdr *hdr, uint32_t fid, uint32_t val); extern void proto_field_set_dev_mac(struct proto_hdr *hdr, uint32_t fid); extern void proto_field_set_default_dev_mac(struct proto_hdr *hdr, uint32_t fid); extern void proto_field_set_dev_ipv4(struct proto_hdr *hdr, uint32_t fid); extern void proto_field_set_default_dev_ipv4(struct proto_hdr *hdr, uint32_t fid); extern void proto_field_set_dev_ipv6(struct proto_hdr *hdr, uint32_t fid); extern void proto_field_set_default_dev_ipv6(struct proto_hdr *hdr, uint32_t fid); extern void proto_field_dyn_apply(struct proto_field *field); extern void proto_field_func_add(struct proto_hdr *hdr, uint32_t fid, struct proto_field_func *func); extern struct proto_field *proto_field_by_id(struct proto_hdr *hdr, uint32_t fid); #endif /* TRAFGEN_PROTO_H */ on value='8'>8space:mode:
authorDouglas Miller <dougmill@linux.vnet.ibm.com>2017-01-28 06:42:20 -0600
committerTejun Heo <tj@kernel.org>2017-01-28 07:49:42 -0500
commit966d2b04e070bc040319aaebfec09e0144dc3341 (patch)
tree4b96156e3d1dd4dfd6039b7c219c9dc4616da52d /tools/perf/Documentation/perf.data-file-format.txt
parent1b1bc42c1692e9b62756323c675a44cb1a1f9dbd (diff)
percpu-refcount: fix reference leak during percpu-atomic transition
percpu_ref_tryget() and percpu_ref_tryget_live() should return "true" IFF they acquire a reference. But the return value from atomic_long_inc_not_zero() is a long and may have high bits set, e.g. PERCPU_COUNT_BIAS, and the return value of the tryget routines is bool so the reference may actually be acquired but the routines return "false" which results in a reference leak since the caller assumes it does not need to do a corresponding percpu_ref_put(). This was seen when performing CPU hotplug during I/O, as hangs in blk_mq_freeze_queue_wait where percpu_ref_kill (blk_mq_freeze_queue_start) raced with percpu_ref_tryget (blk_mq_timeout_work). Sample stack trace: __switch_to+0x2c0/0x450 __schedule+0x2f8/0x970 schedule+0x48/0xc0 blk_mq_freeze_queue_wait+0x94/0x120 blk_mq_queue_reinit_work+0xb8/0x180 blk_mq_queue_reinit_prepare+0x84/0xa0 cpuhp_invoke_callback+0x17c/0x600 cpuhp_up_callbacks+0x58/0x150 _cpu_up+0xf0/0x1c0 do_cpu_up+0x120/0x150 cpu_subsys_online+0x64/0xe0 device_online+0xb4/0x120 online_store+0xb4/0xc0 dev_attr_store+0x68/0xa0 sysfs_kf_write+0x80/0xb0 kernfs_fop_write+0x17c/0x250 __vfs_write+0x6c/0x1e0 vfs_write+0xd0/0x270 SyS_write+0x6c/0x110 system_call+0x38/0xe0 Examination of the queue showed a single reference (no PERCPU_COUNT_BIAS, and __PERCPU_REF_DEAD, __PERCPU_REF_ATOMIC set) and no requests. However, conditions at the time of the race are count of PERCPU_COUNT_BIAS + 0 and __PERCPU_REF_DEAD and __PERCPU_REF_ATOMIC set. The fix is to make the tryget routines use an actual boolean internally instead of the atomic long result truncated to a int. Fixes: e625305b3907 percpu-refcount: make percpu_ref based on longs instead of ints Link: https://bugzilla.kernel.org/show_bug.cgi?id=190751 Signed-off-by: Douglas Miller <dougmill@linux.vnet.ibm.com> Reviewed-by: Jens Axboe <axboe@fb.com> Signed-off-by: Tejun Heo <tj@kernel.org> Fixes: e625305b3907 ("percpu-refcount: make percpu_ref based on longs instead of ints") Cc: stable@vger.kernel.org # v3.18+
Diffstat (limited to 'tools/perf/Documentation/perf.data-file-format.txt')