summaryrefslogtreecommitdiff
path: root/Documentation/Workflow
blob: 9ff3c45cc5354ba169b3baaab1eed6ce306ae8f6 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
Repository Workflow:
////////////////////

Here are some guidelines for users or developers regarding the work with this
Git repository.

* Users:

- steps to verify a release tag can be done with GPG:
	git show maint-dborkman-pgp-pub | gpg --import
	git show maint-tklauser-pgp-pub | gpg --import
	git tag -v <tag-name>

* Developers:

- steps to submit a patch:
	we follow in general a similar submission process as in the Linux kernel
	read https://www.kernel.org/doc/Documentation/SubmittingPatches
	read Documentation/SubmittingPatches
	if a commit was acknowledged by someone, add
		Acked-by: Random J Developer <random@developer.example.org>
	if a bug was reported by someone, add
		Reported-by: Random J Developer <random@developer.example.org>
	if a feature was suggested by someone, add
		Suggested-by: Random J Developer <random@developer.example.org>
	if a commit was tested by someone, add
		Tested-by: Random J Developer <random@developer.example.org>
	if a commit was reviewed by someone, add
		Reviewed-by: Random J Developer <random@developer.example.org>
	if a bug was bisected by someone, add
		Bisected-by: Random J Developer <random@developer.example.org>
	in case tagging as mentioned above already happened internally
	 in your company by different persons, you can add those tags
	 before submission into the patch commit message
	in case someone on the mailing list adds his/her *-by tag, it's the
	 job of the maintainer to keep track of that and to apply this properly

* Maintainer:

- steps to add your public GPG key:
	gpg --gen-key [...]
	gpg --list-keys [take the pubkey id you want to add]
	gpg -a --export <pubid> | git hash-object -w --stdin
	<git-object-id>
	git tag -a maint-<short-name>-pgp-pub <git-object-id>
	<log: Public key of <full name>.>
	git push --tags

- steps to make a new release:
	set proper versioning in the Makefile itself
	make release
	git push --tags
	upload tarballs to public dir
	update website
	email generated .MAIL_MSG to the mailing list, include
	 bcc to the maintainers listed in Documentation/Downstream

- apply patches from non-maintainers, basic rules to follow:
	preferred are patches that have been sent via git send-email
	never do an automatic Github merge in case the pull request came from there
	in case of Github we need to do cherry-picking
	if it's a pull request, make sure it does not contain merges itself
	always add your Signed-off-by to the commit message in case of an apply
	patches must be rejected in case the developer's Signed-off-by is missing
is setting the buf to NULL to annotate an abort has occurred. Replace this mechanism by simply using the state check instead. All the other code in place already uses similar checks for aborting as well so no further changes are needed. An oops can be reproduced with the new fw_fallback.sh fallback mechanism cancellation test. Either cancelling the fallback mechanism or the custom fallback mechanism triggers a crash. mcgrof@piggy ~/linux-next/tools/testing/selftests/firmware (git::20170111-fw-fixes)$ sudo ./fw_fallback.sh ./fw_fallback.sh: timeout works ./fw_fallback.sh: firmware comparison works ./fw_fallback.sh: fallback mechanism works [ this then sits here when it is trying the cancellation test ] Kernel log: test_firmware: loading 'nope-test-firmware.bin' misc test_firmware: Direct firmware load for nope-test-firmware.bin failed with error -2 misc test_firmware: Falling back to user helper BUG: unable to handle kernel NULL pointer dereference at 0000000000000038 IP: _request_firmware+0xa27/0xad0 PGD 0 Oops: 0000 [#1] SMP Modules linked in: test_firmware(E) ... etc ... CPU: 1 PID: 1396 Comm: fw_fallback.sh Tainted: G W E 4.10.0-rc3-next-20170111+ #30 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.10.1-0-g8891697-prebuilt.qemu-project.org 04/01/2014 task: ffff9740b27f4340 task.stack: ffffbb15c0bc8000 RIP: 0010:_request_firmware+0xa27/0xad0 RSP: 0018:ffffbb15c0bcbd10 EFLAGS: 00010246 RAX: 00000000fffffffe RBX: ffff9740afe5aa80 RCX: 0000000000000000 RDX: ffff9740b27f4340 RSI: 0000000000000283 RDI: 0000000000000000 RBP: ffffbb15c0bcbd90 R08: ffffbb15c0bcbcd8 R09: 0000000000000000 R10: 0000000894a0d4b1 R11: 000000000000008c R12: ffffffffc0312480 R13: 0000000000000005 R14: ffff9740b1c32400 R15: 00000000000003e8 FS: 00007f8604422700(0000) GS:ffff9740bfc80000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000000038 CR3: 000000012164c000 CR4: 00000000000006e0 Call Trace: request_firmware+0x37/0x50 trigger_request_store+0x79/0xd0 [test_firmware] dev_attr_store+0x18/0x30 sysfs_kf_write+0x37/0x40 kernfs_fop_write+0x110/0x1a0 __vfs_write+0x37/0x160 ? _cond_resched+0x1a/0x50 vfs_write+0xb5/0x1a0 SyS_write+0x55/0xc0 ? trace_do_page_fault+0x37/0xd0 entry_SYSCALL_64_fastpath+0x1e/0xad RIP: 0033:0x7f8603f49620 RSP: 002b:00007fff6287b788 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 000055c307b110a0 RCX: 00007f8603f49620 RDX: 0000000000000016 RSI: 000055c3084d8a90 RDI: 0000000000000001 RBP: 0000000000000016 R08: 000000000000c0ff R09: 000055c3084d6336 R10: 000055c307b108b0 R11: 0000000000000246 R12: 000055c307b13c80 R13: 000055c3084d6320 R14: 0000000000000000 R15: 00007fff6287b950 Code: 9f 64 84 e8 9c 61 fe ff b8 f4 ff ff ff e9 6b f9 ff ff 48 c7 c7 40 6b 8d 84 89 45 a8 e8 43 84 18 00 49 8b be 00 03 00 00 8b 45 a8 <83> 7f 38 02 74 08 e8 6e ec ff ff 8b 45 a8 49 c7 86 00 03 00 00 RIP: _request_firmware+0xa27/0xad0 RSP: ffffbb15c0bcbd10 CR2: 0000000000000038 ---[ end trace 6d94ac339c133e6f ]--- Fixes: 5d47ec02c37e ("firmware: Correct handling of fw_state_wait() return value") Reported-and-Tested-by: Jakub Kicinski <jakub.kicinski@netronome.com> Reported-and-Tested-by: Patrick Bruenn <p.bruenn@beckhoff.com> Reported-by: Chris Wilson <chris@chris-wilson.co.uk> CC: <stable@vger.kernel.org> [3.10+] Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/irda/irnet/irnet_irda.c')