Drivers: hv: vmbus: finally fix hv_need_to_signal_on_read()

Commit a389fcfd2cb5 ("Drivers: hv: vmbus: Fix signaling logic in
hv_need_to_signal_on_read()")
added the proper mb(), but removed the test "prev_write_sz < pending_sz"
when making the signal decision.

As a result, the guest can signal the host unnecessarily,
and then the host can throttle the guest because the host
thinks the guest is buggy or malicious; finally the user
running stress test can perceive intermittent freeze of
the guest.

This patch brings back the test, and properly handles the
in-place consumption APIs used by NetVSC (see get_next_pkt_raw(),
put_pkt_raw() and commit_rd_index()).

Fixes: a389fcfd2cb5 ("Drivers: hv: vmbus: Fix signaling logic in
hv_need_to_signal_on_read()")

Signed-off-by: Dexuan Cui <decui@microsoft.com>
Reported-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
Tested-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

path: root/REPORTING-BUGS

For reporting bugs send an email to the <netsniff-ng@googlegroups.com> list.

Alternatively, you can create an issue on our Github project:

  * https://github.com/netsniff-ng/netsniff-ng/issues

If you use Fedora or have a RHEL subscription, you can also report bugs to:

  * https://bugzilla.redhat.com/

If you use Debian Linux, we might also process / track bugs there:

  * http://bugs.debian.org/cgi-bin/pkgreport.cgi?src=netsniff-ng

In any way, you'll get a reply from us. Please do not contact individual
developers directly in case of netsniff-ng issues or patches, but rather
always our mailing list. By this, you're not wasting time of a single
developer and increase your chances of getting a reply from us.

In general, we are also highly interested in how you use the toolkit, what
problems you are trying to solve and what kind of things you would like to have
improved. So feel free to drop us some feature requests as well.