summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTobias Klauser <klto@zhaw.ch>2009-10-30 17:18:24 +0100
committerTobias Klauser <klto@zhaw.ch>2009-10-30 17:18:24 +0100
commitdd59f4f38a9e6454d8413ba38fc6d8114954ad72 (patch)
tree40cc818e3ca2338234cdf40ee9aacc319883150f
parent727e55497fa03e9312c1e73bea005233aa03c8d6 (diff)
inotail.c: Add TODO comment to handle_inotify_event
Reopening the watch should only be done in FOLLOW_NAME mode.
-rw-r--r--inotail.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/inotail.c b/inotail.c
index de16a60..d1c30d5 100644
--- a/inotail.c
+++ b/inotail.c
@@ -676,6 +676,10 @@ static int handle_inotify_event(int ifd, struct inotify_event *inev, struct file
else
fprintf(stderr, "File '%s' moved.\n", f->name);
+ /* TODO: This should only be done in FOLLOW_NAME mode, also we
+ * should watch the containing directory until the file
+ * reappears and only then try to install the new watch
+ */
f->i_watch = inotify_add_watch(ifd, f->name, INOTAIL_WATCH_MASK);
if (f->i_watch < 0) {
fprintf(stderr, "Error: Could not create inotify watch on file '%s' (%s)\n",
td> 2013-02-26Merge tag 'for-3.9-rc1' of git://gitorious.org/linux-pwm/linux-pwmLinus Torvalds1-0/+53 2013-01-22pwm: Convert to devm_ioremap_resource()Thierry Reding1-3/+3 2013-01-17pwm: pwm-tiecap: Low power sleep supportPhilip Avinash1-0/+53 2012-12-19Merge tag 'for-3.8-rc1' of git://gitorious.org/linux-pwm/linux-pwmLinus Torvalds1-1/+47 2012-11-28pwm: remove use of __devexitBill Pemberton1-1/+1 2012-11-28pwm: remove use of __devinitBill Pemberton1-1/+1 2012-11-28pwm: remove use of __devexit_pBill Pemberton1-1/+1 2012-11-28pwm: pwm-tiecap: pinctrl supportPhilip, Avinash1-0/+6 2012-11-28pwm: tiecap: Add device-tree bindingPhilip, Avinash1-1/+41 2012-10-05pwm: Check for negative duty-cycle and periodThierry Reding1-1/+1 2012-09-10pwm: pwm-tiecap: Add support for configuring polarity of PWMPhilip, Avinash1-0/+22 2012-09-10pwm: pwm-tiecap: Disable APWM mode after configurePhilip, Avinash1-0/+7 2012-08-17pwm: Remove a redundant error message when devm_request_and_ioremap failsAxel Lin1-3/+1 2012-07-26pwm: pwm-tiecap: PWM driver support for ECAP APWMPhilip, Avinash1-0/+232