diff options
author | Oleg Nesterov <oleg@redhat.com> | 2016-09-26 18:07:48 +0200 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2016-10-14 20:00:34 -0400 |
commit | 89f39af129382a40d7cd1f6914617282cfeee28e (patch) | |
tree | 01c7ce34eda659481fba92293365b3a07c725d16 /Documentation/acpi | |
parent | 655042cc1406fcec20aa7ffd7d790ada18ac5211 (diff) |
fs/super.c: fix race between freeze_super() and thaw_super()
Change thaw_super() to check frozen != SB_FREEZE_COMPLETE rather than
frozen == SB_UNFROZEN, otherwise it can race with freeze_super() which
drops sb->s_umount after SB_FREEZE_WRITE to preserve the lock ordering.
In this case thaw_super() will wrongly call s_op->unfreeze_fs() before
it was actually frozen, and call sb_freeze_unlock() which leads to the
unbalanced percpu_up_write(). Unfortunately lockdep can't detect this,
so this triggers misc BUG_ON()'s in kernel/rcu/sync.c.
Reported-and-tested-by: Nikolay Borisov <kernel@kyup.com>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'Documentation/acpi')
0 files changed, 0 insertions, 0 deletions