summaryrefslogtreecommitdiff
path: root/Documentation
diff options
context:
space:
mode:
authorFilipe Manana <fdmanana@suse.com>2016-05-05 02:08:56 +0100
committerFilipe Manana <fdmanana@suse.com>2016-05-13 01:59:28 +0100
commit376e5a57bf7f1466031a957d04bf8b8f6801ee6d (patch)
treed51e2907047414f8b9798a0122e1a344b024781d /Documentation
parent86e8aa0e772caba5f0e0471d5f836b2b997dcb3e (diff)
Btrfs: pin logs earlier when doing a rename exchange operation
The btrfs_rename_exchange() started as a copy-paste from btrfs_rename(), which had a race fixed by my previous patch titled "Btrfs: pin log earlier when renaming", and so it suffers from the same problem. We pin the logs of the affected roots after we insert the new inode references, leaving a time window where concurrent tasks logging the inodes can end up logging both the new and old references, resulting in log trees that when replayed can turn the metadata into inconsistent states. This behaviour was added to btrfs_rename() in 2009 without any explanation about why not pinning the logs earlier, just leaving a comment about the posibility for the race. As of today it's perfectly safe and sane to pin the logs before we start doing any of the steps involved in the rename operation. Signed-off-by: Filipe Manana <fdmanana@suse.com>
Diffstat (limited to 'Documentation')
0 files changed, 0 insertions, 0 deletions