diff options
author | Arnd Bergmann <arnd@arndb.de> | 2017-02-01 17:46:02 +0100 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2017-02-02 17:12:20 -0500 |
commit | 1f3d62090d3ba4d0c14e5271be87812fc577b197 (patch) | |
tree | 2ba693762d17ffe79265f820d35d54919fd42509 /include/dt-bindings | |
parent | e2160156bf2a7d5018e99a9993fbcdda0abac09b (diff) |
xgene_enet: remove bogus forward declarations
The device match tables for both the xgene_enet driver and its phy driver
have forward declarations that declare an array without a length, leading
to a clang warning when they are not followed by an actual defitinition:
drivers/net/ethernet/apm/xgene/../../../phy/mdio-xgene.h:135:34: warning: tentative array definition assumed to have one element
drivers/net/ethernet/apm/xgene/xgene_enet_main.c:33:36: warning: tentative array definition assumed to have one element
The declarations for the mdio driver are even in a header file, so they
cause duplicate definitions of the tables for each file that includes
them.
This removes all four forward declarations and moves the actual
definitions up a little, so they are in front of their first user. For
the OF match tables, this means having to remove the #ifdef around them,
and passing the actual structure into of_match_device(). This has no
effect on the generated object code though, as the of_match_device
function has an empty stub that does not evaluate its argument, and
the symbol gets dropped either way.
Fixes: 43b3cf6634a4 ("drivers: net: phy: xgene: Add MDIO driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/dt-bindings')
0 files changed, 0 insertions, 0 deletions