iwlwifi: pcie: don't increment / decrement a bool - net-next.git - net-next plumbings

summary refs log tree commit diff

path: root/net/irda

diff options

author	Emmanuel Grumbach <emmanuel.grumbach@intel.com>	2017-01-07 20:11:47 +0200
committer	Luca Coelho <luciano.coelho@intel.com>	2017-02-08 17:54:09 +0200
commit	04fa3e680b4dd2fdd11d0152fb9b6067e7aac140 (patch)
tree	c04bdf5c62d768ead361d599b611afb26e196d8c /net/irda
parent	d45cb20e123c5d7d6cd56301bc98f0bfd725cd77 (diff)

iwlwifi: pcie: don't increment / decrement a bool

David reported that the code I added uses the decrement and increment operator on a boolean variable. Fix that. Fixes: 0cd58eaab148 ("iwlwifi: pcie: allow the op_mode to block the tx queues") Reported-by: David Binderman <dcb314@hotmail.com> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

Diffstat (limited to 'net/irda')

0 files changed, 0 insertions, 0 deletions

ge has tasks on page_waitqueue(page), and is set and cleared under the waitqueue lock. It may be set when there are no tasks on the waitqueue, which will cause a harmless extra wakeup check that will clears the bit. The generic bit-waitqueue infrastructure is no longer used for pages. Instead, waitqueues are used directly with a custom key type. The generic code was not flexible enough to have PageWaiters manipulation under the waitqueue lock (which simplifies concurrency). This improves the performance of page lock intensive microbenchmarks by 2-3%. Putting two bits in the same word opens the opportunity to remove the memory barrier between clearing the lock bit and testing the waiters bit, after some work on the arch primitives (e.g., ensuring memory operand widths match and cover both bits). Signed-off-by: Nicholas Piggin <npiggin@gmail.com> Cc: Dave Hansen <dave.hansen@linux.intel.com> Cc: Bob Peterson <rpeterso@redhat.com> Cc: Steven Whitehouse <swhiteho@redhat.com> Cc: Andrew Lutomirski <luto@kernel.org> Cc: Andreas Gruenbacher <agruenba@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Mel Gorman <mgorman@techsingularity.net> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Diffstat (limited to 'net/x25/x25_out.c')