mlxsw: core: Queue work immediately instead of delaying it - net-next.git - net-next plumbings

summary refs log tree commit diff

path: root/net/netrom

diff options

author	Ido Schimmel <idosch@mellanox.com>	2017-02-06 16:20:10 +0100
committer	David S. Miller <davem@davemloft.net>	2017-02-06 11:25:55 -0500
commit	a0e4761d9bd546eba2e9d3a675863a843624e613 (patch)
tree	3c8cca0661e70b9b36cccb43777631e8cef8b4f9 /net/netrom
parent	fcdc103dac5bdabddd626a4dfe7e5aa5673a61c4 (diff)

mlxsw: core: Queue work immediately instead of delaying it

We always use zero delay before queueing a work on the ordered workqueue ('mlxsw_owq'), so use work_struct directly instead of delayable work. Signed-off-by: Ido Schimmel <idosch@mellanox.com> Signed-off-by: Jiri Pirko <jiri@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>

Diffstat (limited to 'net/netrom')

0 files changed, 0 insertions, 0 deletions

`pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>

Diffstat (limited to 'net/sunrpc/addr.c')