summaryrefslogtreecommitdiff
path: root/include/dt-bindings/power/rk3399-power.h
blob: 168b3bfbd6f5fbff4baca312897d2b279e2057cf (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
#ifndef __DT_BINDINGS_POWER_RK3399_POWER_H__
#define __DT_BINDINGS_POWER_RK3399_POWER_H__

/* VD_CORE_L */
#define RK3399_PD_A53_L0	0
#define RK3399_PD_A53_L1	1
#define RK3399_PD_A53_L2	2
#define RK3399_PD_A53_L3	3
#define RK3399_PD_SCU_L		4

/* VD_CORE_B */
#define RK3399_PD_A72_B0	5
#define RK3399_PD_A72_B1	6
#define RK3399_PD_SCU_B		7

/* VD_LOGIC */
#define RK3399_PD_TCPD0		8
#define RK3399_PD_TCPD1		9
#define RK3399_PD_CCI		10
#define RK3399_PD_CCI0		11
#define RK3399_PD_CCI1		12
#define RK3399_PD_PERILP	13
#define RK3399_PD_PERIHP	14
#define RK3399_PD_VIO		15
#define RK3399_PD_VO		16
#define RK3399_PD_VOPB		17
#define RK3399_PD_VOPL		18
#define RK3399_PD_ISP0		19
#define RK3399_PD_ISP1		20
#define RK3399_PD_HDCP		21
#define RK3399_PD_GMAC		22
#define RK3399_PD_EMMC		23
#define RK3399_PD_USB3		24
#define RK3399_PD_EDP		25
#define RK3399_PD_GIC		26
#define RK3399_PD_SD		27
#define RK3399_PD_SDIOAUDIO	28
#define RK3399_PD_ALIVE		29

/* VD_CENTER */
#define RK3399_PD_CENTER	30
#define RK3399_PD_VCODEC	31
#define RK3399_PD_VDU		32
#define RK3399_PD_RGA		33
#define RK3399_PD_IEP		34

/* VD_GPU */
#define RK3399_PD_GPU		35

/* VD_PMU */
#define RK3399_PD_PMU		36

#endif
long_inc_not_zero() is a long and may have high bits set, e.g. PERCPU_COUNT_BIAS, and the return value of the tryget routines is bool so the reference may actually be acquired but the routines return "false" which results in a reference leak since the caller assumes it does not need to do a corresponding percpu_ref_put(). This was seen when performing CPU hotplug during I/O, as hangs in blk_mq_freeze_queue_wait where percpu_ref_kill (blk_mq_freeze_queue_start) raced with percpu_ref_tryget (blk_mq_timeout_work). Sample stack trace: __switch_to+0x2c0/0x450 __schedule+0x2f8/0x970 schedule+0x48/0xc0 blk_mq_freeze_queue_wait+0x94/0x120 blk_mq_queue_reinit_work+0xb8/0x180 blk_mq_queue_reinit_prepare+0x84/0xa0 cpuhp_invoke_callback+0x17c/0x600 cpuhp_up_callbacks+0x58/0x150 _cpu_up+0xf0/0x1c0 do_cpu_up+0x120/0x150 cpu_subsys_online+0x64/0xe0 device_online+0xb4/0x120 online_store+0xb4/0xc0 dev_attr_store+0x68/0xa0 sysfs_kf_write+0x80/0xb0 kernfs_fop_write+0x17c/0x250 __vfs_write+0x6c/0x1e0 vfs_write+0xd0/0x270 SyS_write+0x6c/0x110 system_call+0x38/0xe0 Examination of the queue showed a single reference (no PERCPU_COUNT_BIAS, and __PERCPU_REF_DEAD, __PERCPU_REF_ATOMIC set) and no requests. However, conditions at the time of the race are count of PERCPU_COUNT_BIAS + 0 and __PERCPU_REF_DEAD and __PERCPU_REF_ATOMIC set. The fix is to make the tryget routines use an actual boolean internally instead of the atomic long result truncated to a int. Fixes: e625305b3907 percpu-refcount: make percpu_ref based on longs instead of ints Link: https://bugzilla.kernel.org/show_bug.cgi?id=190751 Signed-off-by: Douglas Miller <dougmill@linux.vnet.ibm.com> Reviewed-by: Jens Axboe <axboe@fb.com> Signed-off-by: Tejun Heo <tj@kernel.org> Fixes: e625305b3907 ("percpu-refcount: make percpu_ref based on longs instead of ints") Cc: stable@vger.kernel.org # v3.18+
Diffstat (limited to 'sound/soc/codecs/da7219.c')