summaryrefslogtreecommitdiff
path: root/include/dt-bindings/reset/pistachio-resets.h
blob: 60a189b1faef8a54cb97ca188bcd8aab9b2f5998 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
/*
 * This header provides constants for the reset controller
 * present in the Pistachio SoC
 */

#ifndef _PISTACHIO_RESETS_H
#define _PISTACHIO_RESETS_H

#define PISTACHIO_RESET_I2C0		0
#define PISTACHIO_RESET_I2C1		1
#define PISTACHIO_RESET_I2C2		2
#define PISTACHIO_RESET_I2C3		3
#define PISTACHIO_RESET_I2S_IN		4
#define PISTACHIO_RESET_PRL_OUT		5
#define PISTACHIO_RESET_SPDIF_OUT	6
#define PISTACHIO_RESET_SPI		7
#define PISTACHIO_RESET_PWM_PDM		8
#define PISTACHIO_RESET_UART0		9
#define PISTACHIO_RESET_UART1		10
#define PISTACHIO_RESET_QSPI		11
#define PISTACHIO_RESET_MDC		12
#define PISTACHIO_RESET_SDHOST		13
#define PISTACHIO_RESET_ETHERNET	14
#define PISTACHIO_RESET_IR		15
#define PISTACHIO_RESET_HASH		16
#define PISTACHIO_RESET_TIMER		17
#define PISTACHIO_RESET_I2S_OUT		18
#define PISTACHIO_RESET_SPDIF_IN	19
#define PISTACHIO_RESET_EVT		20
#define PISTACHIO_RESET_USB_H		21
#define PISTACHIO_RESET_USB_PR		22
#define PISTACHIO_RESET_USB_PHY_PR	23
#define PISTACHIO_RESET_USB_PHY_PON	24
#define PISTACHIO_RESET_MAX		24

#endif
e return value from atomic_long_inc_not_zero() is a long and may have high bits set, e.g. PERCPU_COUNT_BIAS, and the return value of the tryget routines is bool so the reference may actually be acquired but the routines return "false" which results in a reference leak since the caller assumes it does not need to do a corresponding percpu_ref_put(). This was seen when performing CPU hotplug during I/O, as hangs in blk_mq_freeze_queue_wait where percpu_ref_kill (blk_mq_freeze_queue_start) raced with percpu_ref_tryget (blk_mq_timeout_work). Sample stack trace: __switch_to+0x2c0/0x450 __schedule+0x2f8/0x970 schedule+0x48/0xc0 blk_mq_freeze_queue_wait+0x94/0x120 blk_mq_queue_reinit_work+0xb8/0x180 blk_mq_queue_reinit_prepare+0x84/0xa0 cpuhp_invoke_callback+0x17c/0x600 cpuhp_up_callbacks+0x58/0x150 _cpu_up+0xf0/0x1c0 do_cpu_up+0x120/0x150 cpu_subsys_online+0x64/0xe0 device_online+0xb4/0x120 online_store+0xb4/0xc0 dev_attr_store+0x68/0xa0 sysfs_kf_write+0x80/0xb0 kernfs_fop_write+0x17c/0x250 __vfs_write+0x6c/0x1e0 vfs_write+0xd0/0x270 SyS_write+0x6c/0x110 system_call+0x38/0xe0 Examination of the queue showed a single reference (no PERCPU_COUNT_BIAS, and __PERCPU_REF_DEAD, __PERCPU_REF_ATOMIC set) and no requests. However, conditions at the time of the race are count of PERCPU_COUNT_BIAS + 0 and __PERCPU_REF_DEAD and __PERCPU_REF_ATOMIC set. The fix is to make the tryget routines use an actual boolean internally instead of the atomic long result truncated to a int. Fixes: e625305b3907 percpu-refcount: make percpu_ref based on longs instead of ints Link: https://bugzilla.kernel.org/show_bug.cgi?id=190751 Signed-off-by: Douglas Miller <dougmill@linux.vnet.ibm.com> Reviewed-by: Jens Axboe <axboe@fb.com> Signed-off-by: Tejun Heo <tj@kernel.org> Fixes: e625305b3907 ("percpu-refcount: make percpu_ref based on longs instead of ints") Cc: stable@vger.kernel.org # v3.18+
Diffstat (limited to 'include/net/nfc/hci.h')