flowtop: rcu: omit rcu_assign_pointer

If the new pointer is NULL anyway, this results in a constant expression
during compile time (NULL != NULL) where a barrier is left out. Thus, it
will have no different effect using rcu_assign_pointer() than assigning
it directly.

Signed-off-by: Daniel Borkmann <dborkman@redhat.com>

1 files changed, 3 insertions, 4 deletions

diff --git a/flowtop.c b/flowtop.c
index baa0964..a8b2fe6 100644
--- a/flowtop.c
+++ b/flowtop.c
@@ -366,13 +366,12 @@ static void flow_list_destroy_entry(struct flow_list *fl,
 		n2 = flow_list_find_prev_id(fl, id);
 		if (n2) {
 			rcu_assign_pointer(n2->next, n1->next);
-			rcu_assign_pointer(n1->next, NULL);
+			n1->next = NULL;
 
 			flow_entry_xfree(n1);
 		} else {
 			flow_entry_xfree(fl->head);
-
-			rcu_assign_pointer(fl->head, NULL);
+			fl->head = NULL;
 		}
 	}
 }
@@ -383,7 +382,7 @@ static void flow_list_destroy(struct flow_list *fl)
 
 	while (fl->head != NULL) {
 		n = rcu_dereference(fl->head->next);
-		rcu_assign_pointer(fl->head->next, NULL);
+		fl->head->next = NULL;
 
 		flow_entry_xfree(fl->head);
 		rcu_assign_pointer(fl->head, n);