summaryrefslogtreecommitdiff
path: root/dev.c
diff options
context:
space:
mode:
authorTobias Klauser <tklauser@distanz.ch>2015-04-21 18:05:36 +0200
committerTobias Klauser <tklauser@distanz.ch>2015-04-21 18:05:36 +0200
commit679e6211238039322272e0d3d085fab0d7c5c91d (patch)
tree77efd5b0b13e7edd6de04e2adb7071f014ca4f44 /dev.c
parent04875e8ea51a18dd1466ed7cb5d425c158db4337 (diff)
dev: Close socket in error path of device_ifindex_get()
If the ioctl() fails, the socket still needs to be closed instead of returning directly. This issue was discovered using the Coverity scanner. Fixes: f43bbe9 ("mac80211: Check existence of generated monX device") Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Diffstat (limited to 'dev.c')
-rw-r--r--dev.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/dev.c b/dev.c
index aa0ca4e..2b3a7a5 100644
--- a/dev.c
+++ b/dev.c
@@ -28,9 +28,10 @@ int device_ifindex_get(const char *ifname)
ret = ioctl(sock, SIOCGIFINDEX, &ifr);
if (ret)
- return -1;
+ index = -1;
+ else
+ index = ifr.ifr_ifindex;
- index = ifr.ifr_ifindex;
close(sock);
return index;