Allowing unprivileged kernel profiling lets any user dump follow kernel
control flow and dump kernel registers.  This most likely allows trivial
kASLR bypassing, and it may allow other mischief as well.  (Off the top
of my head, the PERF_SAMPLE_REGS_INTR output during /dev/urandom reads
could be quite interesting.)

Signed-off-by: Andy Lutomirski <luto@kernel.org>
Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

1 files changed, 2 insertions, 2 deletions

diff --git a/staging/mausezahn.c b/staging/mausezahn.c
index c38ea46..6c36166 100644
--- a/staging/mausezahn.c
+++ b/staging/mausezahn.c
@@ -590,8 +590,8 @@ int getopts (int argc, char *argv[])
 			}
 			break;
 		 case '?':
-			if ((optopt == 'a') || (optopt == 'b') || (optopt = 'c') ||
-			    (optopt == 'd') || (optopt == 'f') || (optopt = 'p') ||
+			if ((optopt == 'a') || (optopt == 'b') || (optopt == 'c') ||
+			    (optopt == 'd') || (optopt == 'f') || (optopt == 'p') ||
 			    (optopt == 't') || (optopt == 'm'))
 				fprintf (stderr, " mz/getopts: Option -%c requires an argument.\n", optopt);
 			else if (isprint (optopt))