summaryrefslogtreecommitdiff
path: root/.gitignore
AgeCommit message (Expand)AuthorFilesLines
2009-04-21Added .gitignoreTobias Klauser1-0/+1
elected'>includemode:
authorArnd Bergmann <arnd@arndb.de>2016-03-14 15:22:25 +0100
committerInki Dae <daeinki@gmail.com>2016-04-30 01:03:45 +0900
commit0a938697d7fb8d729afb1ec028566e08854d17f6 (patch)
treef980f39d586cdcb6da009f014947959f656d73cb
parentb89359bdf0f1e95a4c5f92300594ba9dde323fc4 (diff)
drm/exynos: fix error handling in exynos_drm_subdrv_open
gcc-6 warns about a pointless loop in exynos_drm_subdrv_open: drivers/gpu/drm/exynos/exynos_drm_core.c: In function 'exynos_drm_subdrv_open': drivers/gpu/drm/exynos/exynos_drm_core.c:104:199: error: self-comparison always evaluates to false [-Werror=tautological-compare] list_for_each_entry_reverse(subdrv, &subdrv->list, list) { Here, the list_for_each_entry_reverse immediately terminates because the subdrv pointer is compared to itself as the loop end condition. If we were to take the current subdrv pointer as the start of the list (as we would do if list_for_each_entry_reverse() was not a macro), we would iterate backwards over the &exynos_drm_subdrv_list anchor, which would be even worse. Instead, we need to use list_for_each_entry_continue_reverse() to go back over each subdrv that was successfully opened until the first entry. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Inki Dae <inki.dae@samsung.com>
Diffstat